Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geo support #164

Merged
merged 4 commits into from
Dec 17, 2016
Merged

Add Geo support #164

merged 4 commits into from
Dec 17, 2016

Conversation

123avi
Copy link
Contributor

@123avi 123avi commented Dec 10, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 90.369% when pulling ed8c956 on 123avi:master into b62c2aa on etaty:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.551% when pulling 0dea3f7 on 123avi:master into b62c2aa on etaty:master.

@123avi
Copy link
Contributor Author

123avi commented Dec 11, 2016

Hi @etaty , I have added some tests and objects to support geo ,please LMK if that can be merged and when

@etaty
Copy link
Owner

etaty commented Dec 12, 2016

Thanks a lot!

Do you mind making the commands available for redis cluster?
An example for the get command is here :
https://github.com/123avi/rediscala/blob/0dea3f7da3ebeaf84ffcfa7a0b1b4781aecdeb73/src/main/scala/redis/api/Strings.scala#L39-L43

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 90.551% when pulling 38d4951 on 123avi:master into b62c2aa on etaty:master.

@123avi
Copy link
Contributor Author

123avi commented Dec 16, 2016

@etaty Hi, Done. when do you think you can merge it ?

@etaty
Copy link
Owner

etaty commented Dec 17, 2016

Thanks

@etaty etaty merged commit 84ea091 into etaty:master Dec 17, 2016
@etaty etaty added this to the 1.8.0 milestone Dec 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants