Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies.akkaVersion: 2.4.12 -> 2.5.6 #191

Closed
wants to merge 3 commits into from
Closed

Conversation

Ma27
Copy link

@Ma27 Ma27 commented Oct 9, 2017

Akka 2.4 causes a version conflict in one of my projects, so I pushed it to Akka 2.5.x

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 90.903% when pulling 1225ebb on Ma27:update-akka into 55573df on etaty:master.

@Ma27
Copy link
Author

Ma27 commented Oct 9, 2017

@etaty would be cool if this could be merged :-)

@herzrasen
Copy link

+1

Copy link

@herzrasen herzrasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActorSystem.shutdown and ActorSystem.awaitTermination is used in benchmark/src/main/scala/redis/RedisState.scala
Could you fix this as well?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.718% when pulling 1067266 on Ma27:update-akka into 55573df on etaty:master.

@kardapoltsev
Copy link

Any updates?

@Ma27
Copy link
Author

Ma27 commented Jan 14, 2018

@kardapoltsev no, currently waiting for @etaty to get some maintainer's feedback.

@0xd669
Copy link

0xd669 commented Jan 19, 2018

As Akka 2.4.x is deprecated, this should be merged.

@Ma27
Copy link
Author

Ma27 commented Jan 21, 2018

@etaty I absolutely understand it if you don't have enough time to maintian this project anymore. However it seems as there are still people interested in this library. Therefore, would it be possible to give some folks push access so we can continue keeping this library alive?

If this won't be possible I'd suggest that someone of us (I could do this as well, however my OSS time is a bit limited unfortunately) creates a fork to keep this library at least maintained.

@herzrasen
Copy link

@Ma27 I would offer to help maintaining a fork because we'd like to use rediscala at our current project but it is not possible with the minimal maintenance it receives at the moment.

@kardapoltsev
Copy link

kardapoltsev commented Feb 2, 2018

I think I will find some time for maintenance too. I'm interesting in this project.

@Reeebuuk
Copy link

We would also need this

@Ma27
Copy link
Author

Ma27 commented Feb 11, 2018

ok, I just invited @herzrasen, @kardapoltsev and @Reeebuuk to my personal fork. As I'll have to take care of some private things right now, I'll push the changes of my PRs tomorrow and try to setup a build/publishing pipeline so we can easily work on this.

@Reeebuuk
Copy link

I ended up using "net.debasishg" %% "redisclient" % "3.4"
Which is working for me as expected. IE I have a simple cache/session use case.

@Ma27
Copy link
Author

Ma27 commented Feb 15, 2018

FYI I prepared my fork and configured travis, coveralls accordingly, furthermore the fork as available on Maven central: http://search.maven.org/#artifactdetails%7Ccom.github.Ma27%7Crediscala_2.11%7C1.8.1%7Cjar

Sorry for the slight delay, I'm currently busy with a lot of private things and will be blocked by some exams in the next months, so I can only merge things and create releases, no active development.

@KarelCemus
Copy link
Contributor

@Ma27 Great job, very appreciate it! Maybe you could grant push access also to some other maintainers to ensure the fork will be alive?

@etaty Thanks for this amazing library, could you find some time and grant push access to some other maintainers to ensure the continuation of your great work, please? The community would greatly appreciate it.

@Ma27
Copy link
Author

Ma27 commented Feb 27, 2018

@KarelCemus in fact I did, currently @herzrasen, @kardapoltsev and @aoldemeier have push access. In case you’re interested, I can send you an invite as well :)

@Ma27 Ma27 closed this Mar 17, 2018
@Ma27 Ma27 deleted the update-akka branch March 17, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants