-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies.akkaVersion: 2.4.12 -> 2.5.6 #191
Conversation
@etaty would be cool if this could be merged :-) |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ActorSystem.shutdown and ActorSystem.awaitTermination is used in benchmark/src/main/scala/redis/RedisState.scala
Could you fix this as well?
Any updates? |
@kardapoltsev no, currently waiting for @etaty to get some maintainer's feedback. |
As Akka 2.4.x is deprecated, this should be merged. |
@etaty I absolutely understand it if you don't have enough time to maintian this project anymore. However it seems as there are still people interested in this library. Therefore, would it be possible to give some folks push access so we can continue keeping this library alive? If this won't be possible I'd suggest that someone of us (I could do this as well, however my OSS time is a bit limited unfortunately) creates a fork to keep this library at least maintained. |
@Ma27 I would offer to help maintaining a fork because we'd like to use rediscala at our current project but it is not possible with the minimal maintenance it receives at the moment. |
I think I will find some time for maintenance too. I'm interesting in this project. |
We would also need this |
ok, I just invited @herzrasen, @kardapoltsev and @Reeebuuk to my personal fork. As I'll have to take care of some private things right now, I'll push the changes of my PRs tomorrow and try to setup a build/publishing pipeline so we can easily work on this. |
I ended up using "net.debasishg" %% "redisclient" % "3.4" |
FYI I prepared my fork and configured travis, coveralls accordingly, furthermore the fork as available on Maven central: http://search.maven.org/#artifactdetails%7Ccom.github.Ma27%7Crediscala_2.11%7C1.8.1%7Cjar Sorry for the slight delay, I'm currently busy with a lot of private things and will be blocked by some exams in the next months, so I can only merge things and create releases, no active development. |
@Ma27 Great job, very appreciate it! Maybe you could grant push access also to some other maintainers to ensure the fork will be alive? @etaty Thanks for this amazing library, could you find some time and grant push access to some other maintainers to ensure the continuation of your great work, please? The community would greatly appreciate it. |
@KarelCemus in fact I did, currently @herzrasen, @kardapoltsev and @aoldemeier have push access. In case you’re interested, I can send you an invite as well :) |
Akka 2.4 causes a version conflict in one of my projects, so I pushed it to Akka 2.5.x