Fix/add failure behavior #266 (#267)

This MR addresses the behavior mismatch mentioned in #266 Have passed the `EtcdSyncTest`
etcd-cpp-apiv3 · Mar 13, 2024 · ca0e352 · ca0e352
1 parent c911c83
commit ca0e352
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/v3/AsyncGRPC.cpp b/src/v3/AsyncGRPC.cpp
@@ -994,9 +994,9 @@ etcdv3::AsyncSetAction::AsyncSetAction(etcdv3::ActionParameters&& params,
   // backwards compatibility
   txn.add_success_range(parameters.key);
   if (create) {
-    txn.add_failure_put(parameters.key, parameters.value, parameters.lease_id);
-  } else {
     txn.add_failure_range(parameters.key);
+  } else {
+    txn.add_failure_put(parameters.key, parameters.value, parameters.lease_id);
   }
   response_reader =
       parameters.kv_stub->AsyncTxn(&context, *txn.txn_request, &cq_);

diff --git a/tst/EtcdSyncTest.cpp b/tst/EtcdSyncTest.cpp
@@ -18,7 +18,7 @@ TEST_CASE("sync operations") {
   // add
   CHECK(0 == etcd.add("/test/key1", "42").error_code());
   CHECK(etcd::ERROR_KEY_ALREADY_EXISTS ==
-        etcd.add("/test/key1", "42").error_code());  // Key already exists
+        etcd.add("/test/key1", "41").error_code());  // Key already exists
   CHECK("42" == etcd.get("/test/key1").value().as_string());
 
   // modify