Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework file locking #25

Open
heyitsanthony opened this issue Aug 11, 2017 · 1 comment
Open

rework file locking #25

heyitsanthony opened this issue Aug 11, 2017 · 1 comment
Assignees
@cenkalti
Labels
type/feature

Comments

@heyitsanthony
Copy link
Contributor

has a bunch of time.Sleep retry logic; should be closer to etcd's locking
@cenkalti
Copy link
Member

Is this about

bbolt/bolt_unix.go

Line 45 in 160cd29

time.Sleep(flockRetryTimeout)
?

I found on etcd repo flock has no retry logic: https://github.com/etcd-io/etcd/blob/f3c9db9c460bba556f4922a5acc3be496eccda40/client/pkg/fileutil/lock_flock.go#L24-L37

@cenkalti cenkalti self-assigned this May 16, 2023
@github-actions github-actions bot added the stale label Jun 2, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
@ahrtr ahrtr reopened this Jun 23, 2024
@github-actions github-actions bot removed the stale label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cenkalti cenkalti

Labels
type/feature
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cenkalti @heyitsanthony @ahrtr