Upgrade golang to 1.17 and replace iouitl with io and os #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a similar PR etcd/pull/13447 for etcd as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bolt is still using golang 1.12, which is really too old. etcd has already upgraded golang to 1.17, so it'd better to upgrade golang to 1.17 for bolt as well.
The ioutil package has already been deprecated in golang 1.16, please see go1.16#ioutil. So we also need to replace all the ioutil with os and io.
In golang 1.17, the go command understands //go:build lines and prefer them over // +build lines. Please see go1.17#go-command. So added the "//go:build" lines as well in this PR.