Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Fix bbolt keys and bbolt get to prevent them from panicking when no parameter provided #683

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

Elbehery
Copy link
Contributor

cherry-pick of #682

cc @ahrtr @fuweid

@Elbehery Elbehery changed the title fix cli cmds panics [1.3] fix cli cmds panics Jan 29, 2024
@Elbehery Elbehery force-pushed the backport_fix_cli_panics branch 2 times, most recently from 684e1ef to d1d8057 Compare January 30, 2024 15:28
@Elbehery
Copy link
Contributor Author

updated accordingly 👍🏽

Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
@Elbehery
Copy link
Contributor Author

updated this according to the review in #682

@ahrtr ahrtr changed the title [1.3] fix cli cmds panics [1.3] Fix bbolt keys and bbolt get to prevent them from panicking when no parameter provided Jan 31, 2024
@ahrtr
Copy link
Member

ahrtr commented Jan 31, 2024

Fix #681

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@ahrtr ahrtr merged commit 50aef26 into etcd-io:release-1.3 Feb 1, 2024
9 checks passed
@Elbehery Elbehery deleted the backport_fix_cli_panics branch April 22, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants