*: skip logging if logger is discardLogger #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanvc
changed the title
ivanvc
force-pushed
the
supress-logging-for-frequently-called-methods
branch
from
28221b0
to
8eaa55b
Compare
|
/lgtm thank you Ivan. |
ahrtr
reviewed
Apr 30, 2024
If there is no logger defined (discardLogger), skip logging altogether for highly frequent called methods (Put, Delete, CreateBucket, CreateBucketIfNotExists, DeleteBucket, Begin, Commit, Open, MoveBucket, Sync). Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
force-pushed
the
supress-logging-for-frequently-called-methods
branch
from
8eaa55b
to
fbea5d6
Compare
|
Thanks @ivanvc ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no logger defined (discardLogger), skip logging altogether for highly frequent called methods (Put, Delete, CreateBucket, CreateBucketIfNotExists, DeleteBucket, Begin, Commit, Open, MoveBucket, Sync).
There's also no need to convert byte arrays into strings (etcd-io/etcd#17878). So, I simplified these log lines.
Related to #720.