Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update concurrent test to support multiple operations in each transaction #764

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jun 5, 2024

Currently the concurrent test case only executes one operation in each transaction. This PR enhances the test case to support multiple operations in each transaction.

@ahrtr ahrtr force-pushed the enhance_concurrent_test_20240605 branch 2 times, most recently from 5a77713 to 6ab2fe1 Compare June 5, 2024 19:26
@ahrtr ahrtr marked this pull request as draft June 5, 2024 19:47
@ahrtr ahrtr force-pushed the enhance_concurrent_test_20240605 branch from 6ab2fe1 to 07b035d Compare June 5, 2024 20:07
@ahrtr ahrtr marked this pull request as ready for review June 5, 2024 20:20
@ahrtr
Copy link
Member Author

ahrtr commented Jun 6, 2024

cc @fuweid @tjungblu PTAL.

I think we still need to spend more effort on the test, so as try to reproduce the long-standing data corruption issue.

concurrent_test.go Outdated Show resolved Hide resolved
@ahrtr ahrtr force-pushed the enhance_concurrent_test_20240605 branch from 07b035d to 97a498a Compare June 6, 2024 09:15
…tion

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@ahrtr ahrtr force-pushed the enhance_concurrent_test_20240605 branch from 97a498a to 487b5dd Compare June 6, 2024 09:31
@ahrtr
Copy link
Member Author

ahrtr commented Jun 10, 2024

@fuweid @tjungblu Do you have any additional comment on this PR?

@tjungblu
Copy link
Contributor

nope, thank you! /lgtm

@ahrtr
Copy link
Member Author

ahrtr commented Jun 10, 2024

Thanks @tjungblu for the review

@ahrtr ahrtr merged commit e692f9b into etcd-io:main Jun 10, 2024
16 checks passed
@ahrtr ahrtr deleted the enhance_concurrent_test_20240605 branch June 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants