Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back go module files to release-3.3 branch #12233

Closed
gyuho opened this issue Aug 18, 2020 · 4 comments
Closed

Add back go module files to release-3.3 branch #12233

gyuho opened this issue Aug 18, 2020 · 4 comments
Labels

Comments

@gyuho
Copy link
Contributor

gyuho commented Aug 18, 2020

c3780bb

@cfc4n Had to revert this commit in release-3.3 branch because our release script was overwriting the version name string from this go.mod file.

@cfc4n
Copy link
Contributor

cfc4n commented Aug 19, 2020

OK, I see ,thank you.Do I need to do it?

@gyuho
Copy link
Contributor Author

gyuho commented Aug 19, 2020

@cfc4n Yeah that would be great if you can help... Or do you still need module files? I haven't figured out how go module files were affecting version strings...

@cfc4n
Copy link
Contributor

cfc4n commented Aug 19, 2020

I think , most user need module files who troubled by this problem. ref #12068

Can you give some message about release errors?

@stale
Copy link

stale bot commented Nov 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 20, 2020
@stale stale bot closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants