Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codereview]:no close file #13286

Closed
woodliu opened this issue Aug 10, 2021 · 1 comment
Closed

[codereview]:no close file #13286

woodliu opened this issue Aug 10, 2021 · 1 comment
Labels

Comments

@woodliu
Copy link

woodliu commented Aug 10, 2021

// close old wal file; truncate to avoid wasting space if an early cut

As the comment hint , cut will close the current file before create a new encoder. But i see no where close the current file, may be there is a file leak?

@woodliu woodliu closed this as completed Aug 10, 2021
@woodliu woodliu reopened this Aug 10, 2021
@woodliu woodliu changed the title no close file [codereview]:no close file Aug 11, 2021
@stale
Copy link

stale bot commented Nov 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 10, 2021
@stale stale bot closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant