Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track stabilization of --experimental-warning-unary-request-duration flag #13783

Closed
serathius opened this issue Mar 10, 2022 · 1 comment
Closed

Track stabilization of --experimental-warning-unary-request-duration flag #13783

serathius opened this issue Mar 10, 2022 · 1 comment
Labels
help wanted stage/tracked
Milestone
etcd-v3.6

Comments

@serathius
Copy link
Member

serathius commented Mar 10, 2022 •
edited
Loading

This is tracking issue that tracks graduation of this feature. Let's work towards stabilization of the feature by discussing what steps should be taken for graduation.
Context #13775
@serathius serathius added this to the etcd-v3.6 milestone Mar 10, 2022
@serathius serathius changed the title Stabilize --experimental-warning-unary-request-duration flag Track stabilization of --experimental-warning-unary-request-duration flag Mar 14, 2022
@stale stale bot added the stale label Jun 12, 2022
@serathius serathius removed the stale label Jun 13, 2022
@etcd-io etcd-io deleted a comment from stale bot Jun 13, 2022
lavacat pushed a commit to lavacat/etcd that referenced this issue Sep 1, 2022
server: removed 'experimental' from warning-unary-request-duration flag
90d4d9d 
fixes etcd-io#13783
@lavacat lavacat mentioned this issue Sep 1, 2022
Closed
@lavacat
Copy link

lavacat commented Sep 2, 2022 •
edited
Loading

Flag was originally added here #13236
Before the value was hardcoded to 300.

The need for the flag is clear - depending on latency, one can have too much noise in the logs with default 300.
Imo, there is nothing experimental about this flag, so it's ok to rename. It will be less confusing compared to other experimental flags.
cc @spzala

lavacat pushed a commit to lavacat/etcd that referenced this issue Sep 2, 2022
server: removed 'experimental' from warning-unary-request-duration flag
64a9be8 
fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Oct 20, 2022
server: removed 'experimental' from warning-unary-request-duration flag
ffa171a 
experimental-warning-unary-request-duration flag is still present for compatibility until next version, but all vars are updated

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Oct 27, 2022
server: removed 'experimental' from warning-unary-request-duration flag
5addd4c 
experimental-warning-unary-request-duration flag is still present for compatibility until next version, but all vars are updated

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Oct 27, 2022
server: removed 'experimental' from warning-unary-request-duration flag
bc3c2b2 
experimental-warning-unary-request-duration flag is still present for compatibility until next version, but all vars are updated

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Oct 27, 2022
server: added duplicate warning-unary-request-duration flag
7f40dd2 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in next minor release

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Oct 27, 2022
server: added duplicate warning-unary-request-duration flag
947fefc 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in next minor release

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 12, 2022
server: added duplicate warning-unary-request-duration flag
3e05dee 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 12, 2022
server: added duplicate warning-unary-request-duration flag
abee748 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 14, 2022
server: added duplicate warning-unary-request-duration flag
46c0c93 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 14, 2022
server: added duplicate warning-unary-request-duration flag
1b947b6 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 15, 2022
server: added duplicate warning-unary-request-duration flag
2b0e114 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 15, 2022
server: added duplicate warning-unary-request-duration flag
c4f6dd1 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 16, 2022
server: added duplicate warning-unary-request-duration flag
024e839 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 16, 2022
server: added duplicate warning-unary-request-duration flag
5c5525e 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
ahrtr pushed a commit to ahrtr/etcd that referenced this issue Nov 18, 2022
@ahrtr
server: added duplicate warning-unary-request-duration flag
17545e6 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
lavacat pushed a commit to lavacat/etcd that referenced this issue Nov 18, 2022
server: added duplicate warning-unary-request-duration flag
663581b 
--warning-unary-request-duration is a duplicate of --experimental-warning-unary-request-duration
experimental-warning-unary-request-duration will be removed in v3.7.

fixes etcd-io#13783

Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
@ahrtr ahrtr closed this as completed in 7e8ebf7 Nov 18, 2022
@ptabor ptabor mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted stage/tracked
Milestone
etcd-v3.6
Development

Successfully merging a pull request may close this issue.

server: removed 'experimental' from warning-unary-request-duration flag lavacat/etcd
2 participants
@lavacat @serathius