Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: use options for watch commnd #4598

Closed
xiang90 opened this issue Feb 23, 2016 · 3 comments
Closed

clientv3: use options for watch commnd #4598

xiang90 opened this issue Feb 23, 2016 · 3 comments

Comments

@xiang90
Copy link
Contributor

xiang90 commented Feb 23, 2016

we should combine watch and watchPrefix into watch with options as its argument, similar to what we have done for kv api.

/cc @heyitsanthony @gyuho
@gyuho
Copy link
Contributor

gyuho commented Feb 23, 2016

How about WithRev as well?

@xiang90
Copy link
Contributor Author

xiang90 commented Feb 23, 2016

yes.

gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
e36e263 
For etcd-io#4598.
@gyuho gyuho mentioned this issue Feb 24, 2016
Merged
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
160227a 
For etcd-io#4598.
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
4402b68 
For etcd-io#4598.
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
23eb936 
For etcd-io#4598.
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
b791129 
For etcd-io#4598.
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
dc4c772 
For etcd-io#4598.
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
f6e7efa 
For etcd-io#4598.
gyuho added a commit to gyuho/etcd that referenced this issue Feb 24, 2016
@gyuho
clientv3: combine Watch, WatchPrefix with variadic
a24d276 
For etcd-io#4598.
@gyuho
Copy link
Contributor

gyuho commented Feb 24, 2016

Closing via #4602.

@gyuho gyuho closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiang90 @gyuho