Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: evaluate 'github.com/golang/dep' #7225

Closed
gyuho opened this issue Jan 24, 2017 · 6 comments
Closed

vendor: evaluate 'github.com/golang/dep' #7225

gyuho opened this issue Jan 24, 2017 · 6 comments
Assignees
Milestone

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 24, 2017

Experiment with official Go's dependency management tool https://github.com/golang/dep

@xiang90 xiang90 added this to the v3.3.0 milestone Jan 26, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Mar 4, 2017

We can't use this until this is addressed golang/dep#120.
Currently dep would introduce extra >1million lines of vendor code.

@xiang90
Copy link
Contributor

xiang90 commented Jun 19, 2017

i do not believe this can happen in 3.3 release cycle based on the progress of golang/dep. @gyuho can we move this out of 3.3?

@gyuho gyuho modified the milestones: unplanned, v3.3.0 Jun 19, 2017
@olivere
Copy link

olivere commented Oct 13, 2017

As asked in #8692, here's my very brief summary of checking with dep again, on my fork of etcd on a MBP.

$ uname -a
Darwin violet 17.0.0 Darwin Kernel Version 17.0.0: Thu Aug 24 21:48:19 PDT 2017; root:xnu-4570.1.46~2/RELEASE_X86_64 x86_64
$ glide -v
glide version 0.13.0
$ rm -rf vendor
$ glide i
...
violet master … github.com/olivere/etcd $ du -h vendor | wc -l
     802
violet master … github.com/olivere/etcd $ du -h vendor | tail -1
 74M	vendor

Next up, dep:

$ dep version
dep:
 version     : devel
 build date  :
 git hash    :
 go version  : go1.9.1
 go compiler : gc
 platform    : darwin/amd64
$ rm -rf vendor
$ dep init
Importing configuration from glide. These are only initial constraints, and are further refined during the solve process.
Detected glide configuration files...
Converting from glide.yaml and glide.lock...
  Using ^0.1.0 as initial constraint for imported dep github.com/bgentry/speakeasy
  Trying v0.1.0 (4aabc24) as initial lock for imported dep github.com/bgentry/speakeasy
  Using ^1.3.1-coreos.2 as initial constraint for imported dep github.com/coreos/bbolt
  Trying v1.3.1-coreos.2 (54f6fad) as initial lock for imported dep github.com/coreos/bbolt
...
$ du -h vendor | wc -l
     955
$ du -h vendor | tail -1
 94M	vendor

@gyuho
Copy link
Contributor Author

gyuho commented Oct 13, 2017

I remember we had to add some [[override]] rules.

@olivere
Copy link

olivere commented Oct 13, 2017

@gyuho Sorry. I just updated my findings--I forgot to merge from upstream first. The numbers changed a bit, but the end result is basically the same.

@gyuho gyuho modified the milestones: unplanned, v3.4.0 Dec 12, 2017
@gyuho
Copy link
Contributor Author

gyuho commented Jan 12, 2018

Plan to migrate to dep after 3.3 release. I migrated another project with dep

  1. https://github.com/coreos/dbtester/blob/master/scripts/updatedep.sh
  2. https://github.com/coreos/dbtester/blob/master/Gopkg.toml
  3. https://github.com/coreos/dbtester/blob/master/.gitignore

We need .gitignore updates until dep implements pruning.

ntoofu added a commit to ntoofu/coredns-plugin-etcdhcp that referenced this issue Jul 16, 2018
Add files required by `dep`, vendoring tool for Go.
Gopkg.toml contains some workaround against an `etcd` issue like
[this](https://github.com/coreos/dbtester/blob/61e613d8ff485db212921b022e62796c3b8ad5a0/Gopkg.toml).
See etcd-io/etcd#7225 for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants