Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestRegister: race on grpc/transport.(*Stream).BytesReceived() #8141

Closed
gyuho opened this issue Jun 20, 2017 · 0 comments
Closed

TestRegister: race on grpc/transport.(*Stream).BytesReceived() #8141

gyuho opened this issue Jun 20, 2017 · 0 comments

Comments

@gyuho
Copy link
Contributor

gyuho commented Jun 20, 2017

Just as reference for future failures

==================
WARNING: DATA RACE
Read at 0x00c42000baf1 by goroutine 146:
  google.golang.org/grpc/transport.(*Stream).BytesReceived()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/transport/transport.go:377 +0x91
  google.golang.org/grpc.invoke()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/call.go:302 +0x1836
  google.golang.org/grpc.Invoke()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/call.go:152 +0x216
  github.com/coreos/etcd/etcdserver/etcdserverpb.(*kVClient).Put()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/etcdserver/etcdserverpb/rpc.pb.go:3000 +0x106
  github.com/coreos/etcd/clientv3.(*retryWriteKVClient).Put.func1()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/retry.go:105 +0xe8
  github.com/coreos/etcd/clientv3.(*Client).newRetryWrapper.func1()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/retry.go:31 +0x82
  github.com/coreos/etcd/clientv3.(*retryWriteKVClient).Put()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/retry.go:107 +0x246
  github.com/coreos/etcd/clientv3.(*retryWriteKVClient).Put.func1()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/retry.go:105 +0xe8
  github.com/coreos/etcd/clientv3.(*Client).newAuthRetryWrapper.func1()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/retry.go:61 +0x5e
  github.com/coreos/etcd/clientv3.(*retryWriteKVClient).Put()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/retry.go:107 +0x246
  github.com/coreos/etcd/clientv3.(*retryKVClient).Put()
      <autogenerated>:205 +0xb1
  github.com/coreos/etcd/clientv3.(*kv).do()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/kv.go:147 +0x4f6
  github.com/coreos/etcd/clientv3.(*kv).Do()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/kv.go:119 +0x95
  github.com/coreos/etcd/clientv3.(*kv).Put()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/kv.go:88 +0x10c
  github.com/coreos/etcd/clientv3/naming.(*GRPCResolver).Update()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/clientv3/naming/grpc.go:44 +0x451
  github.com/coreos/etcd/proxy/grpcproxy.registerSession()
      github.com/coreos/etcd/proxy/grpcproxy/_test/_obj_test/register.go:80 +0x345
  github.com/coreos/etcd/proxy/grpcproxy.Register.func1()
      github.com/coreos/etcd/proxy/grpcproxy/_test/_obj_test/register.go:44 +0x177

Previous write at 0x00c42000baf1 by goroutine 106:
  google.golang.org/grpc/transport.(*http2Client).operateHeaders()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/transport/http2_client.go:1027 +0x93
  google.golang.org/grpc/transport.(*http2Client).reader()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/transport/http2_client.go:1142 +0x8f8

Goroutine 146 (running) created at:
  github.com/coreos/etcd/proxy/grpcproxy.Register()
      github.com/coreos/etcd/proxy/grpcproxy/_test/_obj_test/register.go:64 +0x164
  github.com/coreos/etcd/proxy/grpcproxy.TestRegister()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/github.com/coreos/etcd/proxy/grpcproxy/register_test.go:47 +0x3a4
  testing.tRunner()
      /usr/local/golang/1.8.1/go/src/testing/testing.go:657 +0x107

Goroutine 106 (running) created at:
  google.golang.org/grpc/transport.newHTTP2Client()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/transport/http2_client.go:267 +0x12ec
  google.golang.org/grpc/transport.NewClientTransport()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/transport/transport.go:463 +0xbe
  google.golang.org/grpc.(*addrConn).resetTransport()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/clientconn.go:876 +0x414
  google.golang.org/grpc.(*ClientConn).resetAddrConn.func1()
      /home/runner/workspace/src/github.com/coreos/etcd/gopath/src/google.golang.org/grpc/clientconn.go:648 +0x41
==================
2017-06-20 17:31:52.703415 W | grpcproxy: failed to create a session context canceled
2017-06-20 17:31:52.703804 I | integration: terminating 6192290235737658977 (unix://localhost:61922902357376589770)
2017-06-20 17:31:52.721167 I | integration: terminated 6192290235737658977 (unix://localhost:61922902357376589770)
--- FAIL: TestRegister (0.08s)
	testing.go:610: race detected during execution of test

Will close this when we vendor grpc 1.4.2.

Ref. grpc/grpc-go#1318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant