Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect bytesSent and bytesReceived with mutex to avoid datarace #1318

Merged
merged 1 commit into from Jun 19, 2017
Merged

Protect bytesSent and bytesReceived with mutex to avoid datarace #1318

merged 1 commit into from Jun 19, 2017

Conversation

menghanl
Copy link
Contributor

fixes #1316

@gyuho
Copy link
Contributor

gyuho commented Jun 18, 2017

Can we do another release with this? Thanks!

@menghanl menghanl merged commit 40e7a75 into grpc:master Jun 19, 2017
@menghanl menghanl deleted the fix_race_bytes_read branch June 19, 2017 20:57
@menghanl
Copy link
Contributor Author

menghanl commented Jun 19, 2017 •
edited

@gyuho We try to not release too frequently, hopefully not more than one release per week, except for severe bugs.
We will do a release later this week, which will include the fix here.

@gyuho gyuho mentioned this pull request Jun 20, 2017
Closed
menghanl added a commit that referenced this pull request Jun 22, 2017
@menghanl
Protect bytesSent and bytesReceived with mutex to avoid datarace (#1318)
987e313
@fraenkel fraenkel mentioned this pull request Aug 30, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MakMukhi MakMukhi MakMukhi approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transport: data race between http2Client.operateHeaders() and Stream.BytesReceived()
3 participants
@menghanl @gyuho @MakMukhi