Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize gRPC gateway (/v3beta) #9189

Closed
gyuho opened this issue Jan 22, 2018 · 18 comments
Closed

Stabilize gRPC gateway (/v3beta) #9189

gyuho opened this issue Jan 22, 2018 · 18 comments
Assignees

Comments

@gyuho
Copy link
Contributor

gyuho commented Jan 22, 2018

gRPC gateway serves /v3beta, should be ready as /v3

Reference #9064.

Not much to do here. Just trouble-shoot any issues that may come up. Or add any missing tests. And bump up endpoint to v3 before 3.4 release.

@hexfusion Do you want to work on this?

@hexfusion
Copy link
Contributor

@gyuho I am a user of gRPC gateway and would love to see it stable /v3. Will try my best to support/improve.

@hexfusion hexfusion self-assigned this Jan 22, 2018
@gyuho
Copy link
Contributor Author

gyuho commented Jan 22, 2018

@hexfusion Thanks! Reference when bumping up to /v3 (#8880).

@xiang90
Copy link
Contributor

xiang90 commented Jan 26, 2018

the thing i worry about is that gRPC web is probably going to release soon. it can be the "official" way to expose gRPC service in JSON format.

@hexfusion
Copy link
Contributor

hexfusion commented Jan 26, 2018

@xiang90 does it make sense to make /v3 stable with grpc-gateway then look at grpc/grpc#8682 for /v4? Replacing seems a fair bit of work :).

@gyuho
Copy link
Contributor Author

gyuho commented Jan 26, 2018

We will double-check with gRPC team.

@hexfusion
Copy link
Contributor

hexfusion commented Jan 29, 2018

I got the ball rolling here a little.

@xiang90
Copy link
Contributor

xiang90 commented Jan 29, 2018

@gyuho @hexfusion

this is the gRPC web issue: grpc/grpc#8682.

It is an official gRPC support instead of the one from improbable.

@hexfusion
Copy link
Contributor

I see thanks.

@hexfusion
Copy link
Contributor

@xiang90 @gyuho either of you getting early access per comments in issue?

@gyuho
Copy link
Contributor Author

gyuho commented Jan 29, 2018

@hexfusion No, but seems like it should be out in a few weeks?

@gyuho gyuho changed the title Stabilize gRPC gateway (/v3beta) Stabilize gRPC gateway (/v3beta) or evaludate grpc/grpc-web Jan 29, 2018
@hexfusion
Copy link
Contributor

I asked for early access to get a feel for how this will look.

@hexfusion
Copy link
Contributor

@gyuho @xiang90
small snippet from readme re: grpc-web

The gateway that connects the client to the server uses Nginx. However, Nginx still doesn't support HTTP/2 (to backends) as of Q3/2017, and therefore the gateway can't be used as a reverse proxy (for load balancing). We have also added the gRPC-Web support to Envoy. In future, we expect gRPC-Web to be supported in language-specific Web frameworks too, such as Go, Java, Node, which will eliminate the need to deploy a gateway.

Being that it has a Nginx/Envoy dependency currently I do not see this becoming a short term alternative to grpc-gateway. A side car approach could be possible allowing maybe etcd-operator more reasonable support via Kubernetes. But still a ways off it seems for direct Go implimentation from gRPC team?

@xiang90
Copy link
Contributor

xiang90 commented Feb 1, 2018

OK. It seems like gRPC-web really only focuses on the Web part for web app builders rather than the ease of use as a JSON+HTTP API? If that is the case, let us move forward with grpc-gateway.

@gyuho
Copy link
Contributor Author

gyuho commented Feb 1, 2018

@hexfusion @xiang90 Sounds good. People already depend on our current grpc-gateway anyway.

@hexfusion
Copy link
Contributor

hexfusion commented Feb 1, 2018

Understood grpc-gateway /v3 ahead!

@hexfusion hexfusion changed the title Stabilize gRPC gateway (/v3beta) or evaludate grpc/grpc-web Stabilize gRPC gateway (/v3beta) Feb 1, 2018
@hexfusion
Copy link
Contributor

Going to start on this tonight.

@hexfusion
Copy link
Contributor

@gyuho @xiang90 do we want to support /v3beta and /v3 depreciating /v3alpha or only support /v3 for 3.4?

@stale
Copy link

stale bot commented Apr 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 7, 2020
@stale stale bot closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants