Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdctl: fix strings.HasPrefix args order #10443

Merged
merged 1 commit into from
Feb 2, 2019
Merged

etcdctl: fix strings.HasPrefix args order #10443

merged 1 commit into from
Feb 2, 2019

Conversation

quasilyte
Copy link
Contributor

Signed-off-by: Iskander Sharipov quasilyte@gmail.com

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #10443 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10443      +/-   ##
==========================================
- Coverage   71.61%   71.58%   -0.03%     
==========================================
  Files         392      392              
  Lines       36489    36489              
==========================================
- Hits        26131    26122       -9     
- Misses       8531     8543      +12     
+ Partials     1827     1824       -3
Impacted Files Coverage Δ
etcdctl/ctlv2/command/util.go 45.5% <0%> (ø) ⬆️
etcdctl/ctlv3/command/global.go 59% <0%> (ø) ⬆️
proxy/grpcproxy/register.go 69.44% <0%> (-11.12%) ⬇️
clientv3/leasing/util.go 91.66% <0%> (-6.67%) ⬇️
proxy/grpcproxy/watch.go 88.55% <0%> (-4.22%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
proxy/httpproxy/director.go 80% <0%> (-2.86%) ⬇️
etcdserver/api/v2http/client.go 85.51% <0%> (-1.21%) ⬇️
clientv3/watch.go 91.1% <0%> (-0.64%) ⬇️
clientv3/balancer/grpc1.7-health.go 59.3% <0%> (-0.59%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0f0ba...48a2442. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Feb 2, 2019

lgtm

@xiang90
Copy link
Contributor

xiang90 commented Feb 2, 2019

/cc @gyuho @jpbetz needs to be back-ported i think.

@jpbetz
Copy link
Contributor

jpbetz commented Feb 5, 2019

jpbetz added a commit that referenced this pull request Feb 6, 2019
…-origin-release-3.2

Automated cherry pick of #10443 to release 3.2
jpbetz added a commit that referenced this pull request Feb 6, 2019
…-origin-release-3.1

Automated cherry pick of #10443 to release 3.1
jpbetz pushed a commit to jpbetz/etcd that referenced this pull request Feb 6, 2019
jpbetz pushed a commit to jpbetz/etcd that referenced this pull request Feb 6, 2019
gyuho added a commit that referenced this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants