etcd: Replace ghodss/yaml with sigs.k8s.io/yaml #10718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see happened in test cases. Can you check why? details: https://travis-ci.com/etcd-io/etcd/jobs/198142245 |
@xiang90 , I observed this failure in my PR as well : #10687 , but when I ran the test locally , it is able to pull the dependency correctly. I am not sure why the timeout occurs intermittently for this dependency in the CI. |
rohitsardesai83
force-pushed
the
release-3.3
branch
from
e517a6e
to
8ed3e70
Compare
rohitsardesai83
commented
May 29, 2019
| @@ -126,7 +126,7 @@ import: | |||
| - package: gopkg.in/cheggaaa/pb.v1 | |||
| version: v1.0.2 | |||
| - package: gopkg.in/yaml.v2 | |||
| version: cd8b52f8269e0feb286dfeef29f8fe4d5b397e0b | |||
| version: 51d6538a90f86fe93ac480b35f37b2be17fef232 | |||
There was a problem hiding this comment.
sigs.k8s.io/yaml uses this version of gopkg.in/yaml.v2.
3 tasks
|
@rohitsardesai83 Can you create a separate PR to highlight this in changelog? |
|
@rohitsardesai83 You can just copy the line from CHANGELOG-3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To remove the dependency on ghodss/yaml. Replaced this dependency with sigs.k8s.io/yaml.
This wil help to remove the ghodss/yaml dependency from main kubernetes repository.
See :
github.com/ghodss/yamlwithsigs.k8s.io/yaml#10687.This pull request was raised against the master branch.
Kubernetes uses etcd 3.3, so need to backport this fix to 3.3.