Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: promote etcd_debugging_mvcc put_total and delete_total #10962

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

hexfusion
Copy link
Contributor

This PR promotes the following experimental metrics to stable.

  • etcd_debugging_mvcc_put_total -> etcd_mvcc_put_total
  • etcd_debugging_mvcc_delete_total -> etcd_mvcc_delete_total

Fixes #10950

/cc @p0lyn0mial

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@codecov-io
Copy link

codecov-io commented Aug 1, 2019

Codecov Report

Merging #10962 into master will increase coverage by 0.77%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10962      +/-   ##
==========================================
+ Coverage   64.21%   64.98%   +0.77%     
==========================================
  Files         401      401              
  Lines       37473    38222     +749     
==========================================
+ Hits        24062    24838     +776     
+ Misses      11804    11730      -74     
- Partials     1607     1654      +47
Impacted Files Coverage Δ
mvcc/metrics.go 91.66% <ø> (ø) ⬆️
mvcc/metrics_txn.go 100% <100%> (ø) ⬆️
pkg/tlsutil/tlsutil.go 86.2% <0%> (-6.9%) ⬇️
pkg/fileutil/purge.go 65.9% <0%> (-6.82%) ⬇️
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
pkg/mock/mockserver/mockserver.go 72.72% <0%> (-2.28%) ⬇️
clientv3/balancer/balancer.go 86.36% <0%> (-2.28%) ⬇️
mvcc/watchable_store.go 83.5% <0%> (-1.76%) ⬇️
embed/etcd.go 68.5% <0%> (+0.39%) ⬆️
etcdserver/v3_server.go 72.43% <0%> (+0.45%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149e5dc...f46ee91. Read the comment docs.

@gyuho gyuho merged commit 5ef8f27 into etcd-io:master Aug 1, 2019
@gyuho
Copy link
Contributor

gyuho commented Aug 1, 2019

@jingyih Txn metrics would combine those changes (ranges + puts + deletes)

@gyuho
Copy link
Contributor

gyuho commented Aug 1, 2019

This PR is missing register calls for putCounterDebug. Let me send a PR to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

metrics: promote etcd_debugging put_total and delete_total
3 participants