Deprecate "grpc.ErrClientConnClosing" #10981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
deprecate-grpc-clientconnclosing
branch
from
abf7f92
to
b3cd4f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #10981 +/- ##
==========================================
+ Coverage 63.5% 64.11% +0.61%
==========================================
Files 401 401
Lines 37552 37551 -1
==========================================
+ Hits 23847 24077 +230
+ Misses 12089 11844 -245
- Partials 1616 1630 +14
Continue to review full report at Codecov.
|
spzala
reviewed
Aug 5, 2019
CHANGELOG-3.4.md
Outdated
| @@ -125,6 +125,9 @@ See [code changes](https://github.com/etcd-io/etcd/compare/v3.3.0...v3.4.0) and | |||
| - v3.5 will deprecate `etcd --debug` flag in favor of `etcd --log-level=debug`. | |||
| - Change v3 `etcdctl snapshot` exit codes with [`snapshot` package](https://github.com/etcd-io/etcd/pull/9118/commits/df689f4280e1cce4b9d61300be13ca604d41670a). | |||
| - Exit on error with exit code 1 (no more exit code 5 or 6 on `snapshot save/restore` commands). | |||
| - Deprecate [`grpc.ErrClientConnClosing`](https://github.com/etcd-io/etcd/pull/10981). | |||
There was a problem hiding this comment.
@gyuho just a nit - useDeprecating (or Deprecated) instead of Deprecate to be consistent with the rest of the changelog and other places like upgrade_3_4.md?
There was a problem hiding this comment.
Since this is due to the grpc upgrade, put the exact grpc upgrade version as a high level release change note and put this item as note beneath it?
CHANGELOG-3.4.md
Outdated
| @@ -449,6 +452,9 @@ Note: **v3.5 will deprecate `etcd --log-package-levels` flag for `capnslog`**; ` | |||
| - `PermitWithoutStream` is set to false by default. | |||
| - Fix logic on [release lock key if cancelled](https://github.com/etcd-io/etcd/pull/10153) in `clientv3/concurrency` package. | |||
| - Fix [`(*Client).Endpoints()` method race condition](https://github.com/etcd-io/etcd/pull/10595). | |||
| - Deprecate [`grpc.ErrClientConnClosing`](https://github.com/etcd-io/etcd/pull/10981). | |||
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
gyuho
force-pushed
the
deprecate-grpc-clientconnclosing
branch
from
b3cd4f2
to
a0cabb5
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9304.