integration: fix bug in for loop, make it break properly #11153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingyih
reviewed
Sep 16, 2019
clientv3/integration/cluster_test.go
Outdated
| for { | ||
| select { | ||
| case <-time.After(500 * time.Millisecond): | ||
| case <-timeout: | ||
| t.Errorf("failed all attempts to promote learner member, last error: %v", err) | ||
| break | ||
| break promLoop |
There was a problem hiding this comment.
Good catch! Can we use t.Fatalf here?
There was a problem hiding this comment.
Chnage to t.Fataf, in this case, the break is no need anymore
|
Also, please change commit title to use format |
beautytiger
force-pushed
the
dev-190916
branch
from
c69b5dc
to
6287052
Compare
beautytiger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The break statement should break the outer for loop, or it will run forever.
Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.