Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcdserver: cherry-pick skip client san verification option for 3.3 version. #11196

Merged
merged 3 commits into from
Oct 9, 2019
Merged

etcdserver: cherry-pick skip client san verification option for 3.3 version. #11196

merged 3 commits into from
Oct 9, 2019

Conversation

andyliuliming
Copy link
Contributor

No description provided.

@andyliuliming @MartinWeindel @jingyih
etcdserver: cherry-pick skip client san verification option for 3.3 v…
86b1686 
…ersion.

Co-authored-by: Martin Weindel <martin.weindel@sap.com>
Co-authored-by: Jingyi Hu <jingyih@google.com>
Co-authored-by: Liming Liu <andyliuliming@outlook.com>
@wenjiaswe
Copy link
Contributor

wenjiaswe commented Oct 8, 2019 •
edited

Original pr: #10524

/lgtm for me. Defer to @hexfusion to decide if this is feasible to backport to previous version. Note: this does not change the default behavior.

It would be great if you could also update the documentation: #11045, Documentation/op-guide/configuration.md and CHANGELOG.

@wenjiaswe wenjiaswe mentioned this pull request Oct 8, 2019
Merged
@jpbetz
Copy link
Contributor

jpbetz commented Oct 8, 2019

Typically we do not backport features. But given that this is behind an experimental flag and is causing real user pain, I'm in favor of it. @gyuho What do you think?

@gyuho
Copy link
Contributor

gyuho commented Oct 8, 2019

@jpbetz @wenjiaswe Sounds good. @andyliuliming Can we also highlight these in CHANGELOG?

@andyliuliming
Copy link
Contributor Author

andyliuliming commented Oct 9, 2019 •
edited

@wenjiaswe @jpbetz @gyuho thanks for the review.
updated the document &
send another PR to add the changelog (based on my imagination :) not sure that's the right change ):
#11219
because did not found the changelog file in this release branch.

@wenjiaswe
Copy link
Contributor

lgtm, thanks.

@gyuho gyuho merged commit 011bd86 into etcd-io:release-3.3 Oct 9, 2019
@hydracz hydracz mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hexfusion hexfusion

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andyliuliming @wenjiaswe @jpbetz @gyuho @hexfusion