Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: add "etcd_mvcc_put_size_in_bytes" metrics #11374

Merged
merged 2 commits into from Nov 20, 2019

Conversation

YoyinZyc
Copy link
Contributor

related #11365
@logicalhan @jingyih Please have a look.

@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #11374 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11374      +/-   ##
==========================================
+ Coverage   64.34%   64.64%   +0.29%     
==========================================
  Files         403      403              
  Lines       37969    37973       +4     
==========================================
+ Hits        24432    24548     +116     
+ Misses      11887    11779     -108     
+ Partials     1650     1646       -4
Impacted Files Coverage Δ
mvcc/metrics_txn.go 100% <100%> (ø) ⬆️
mvcc/metrics.go 91.04% <100%> (+0.13%) ⬆️
etcdserver/api/v3rpc/lease.go 69.31% <0%> (-5.69%) ⬇️
clientv3/maintenance.go 40.81% <0%> (-2.05%) ⬇️
clientv3/op.go 72.08% <0%> (-1.25%) ⬇️
etcdserver/cluster_util.go 56.52% <0%> (-0.8%) ⬇️
raft/raft.go 89.91% <0%> (-0.64%) ⬇️
clientv3/leasing/cache.go 87.22% <0%> (-0.56%) ⬇️
etcdserver/server.go 68.53% <0%> (-0.2%) ⬇️
pkg/transport/timeout_conn.go 80% <0%> (ø) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b373cb9...a5e747b. Read the comment docs.

Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Added few nits.

mvcc/metrics.go Outdated Show resolved Hide resolved
mvcc/metrics.go Outdated Show resolved Hide resolved
mvcc/metrics.go Outdated Show resolved Hide resolved
@jingyih
Copy link
Contributor

jingyih commented Nov 20, 2019

LGTM

Might as well add for range and delete?

Copy link

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is great! Thanks so much!

/lgtm

@jingyih jingyih merged commit 908ef19 into etcd-io:master Nov 20, 2019
wenjiaswe added a commit that referenced this pull request Nov 26, 2019
…4-upstream-release-3.3

Automated cherry pick of #11374 on release 3.3
wenjiaswe added a commit that referenced this pull request Nov 26, 2019
…4-upstream-release-3.4

Automated cherry pick of #11374 on release 3.4
wenjiaswe added a commit that referenced this pull request Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants