Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick of #11564 #11880

Conversation

gdbelvin
Copy link

@gdbelvin gdbelvin commented May 11, 2020

Cherry pick of

on release-3.4.

gyuho and others added 2 commits May 11, 2020 21:10
Picking up some performance improvements and bug fixes.

https://github.com/grpc/grpc-go/releases/tag/v1.24.0

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gdbelvin gdbelvin marked this pull request as ready for review May 11, 2020 22:16
@gdbelvin gdbelvin force-pushed the automated-cherry-pick-of-#11564-upstream-release-3.4 branch from 7ead1e6 to cfe2885 Compare May 11, 2020 22:23
@gdbelvin gdbelvin changed the title Automated cherry pick of #11564 cherry pick of #11564 May 12, 2020
@gdbelvin
Copy link
Author

@gyuho does this look ok?
How should I update the CHANGELIST? it didn't seem present in this branch.

@xiang90
Copy link
Contributor

xiang90 commented May 12, 2020

@gdbelvin

Have you checked that this backport does make go mod happy?

@gdbelvin
Copy link
Author

@xiang90

This makes go mod happy with go 1.12.12
I've just pushed a commit that makes this happy with go 1.14 as well. Is that what you were referring to?

@gdbelvin gdbelvin force-pushed the automated-cherry-pick-of-#11564-upstream-release-3.4 branch from aca623b to 0ee2443 Compare May 13, 2020 12:20
@gdbelvin gdbelvin force-pushed the automated-cherry-pick-of-#11564-upstream-release-3.4 branch from 0ee2443 to c008299 Compare May 13, 2020 13:04
@xiang90 xiang90 merged commit e048e16 into etcd-io:release-3.4 May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants