raft: check pending conf change before campaign #12134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Jul 20, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #12134 +/- ##
==========================================
- Coverage 63.96% 63.28% -0.68%
==========================================
Files 403 403
Lines 37369 37389 +20
==========================================
- Hits 23902 23661 -241
- Misses 11942 12199 +257
- Partials 1525 1529 +4
Continue to review full report at Codecov.
|
|
@BusyJay Create a separate PR for the 3rd commit since it is not relevant to |
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
|
The commit is removed. |
|
lgtm |
cfc4n
reviewed
Jul 23, 2020
| } | ||
| ents, err := r.raftLog.slice(r.raftLog.applied+1, r.raftLog.committed+1, noLimit) | ||
| if err != nil { | ||
| r.logger.Panicf("unexpected error getting unapplied entries (%v)", err) |
There was a problem hiding this comment.
Is there need return err ?
I can't pass unit tests with error
https://travis-ci.com/github/etcd-io/etcd/jobs/363601925#L3846
raft2020/07/23 19:40:17 unexpected error getting unapplied entries (requested index is unavailable due to compaction)
--- FAIL: TestLeaderTransferAfterSnapshot (0.00s)
panic: unexpected error getting unapplied entries (requested index is unavailable due to compaction) [recovered]
panic: unexpected error getting unapplied entries (requested index is unavailable due to compaction)
goroutine 213 [running]:
testing.tRunner.func1.1(0xba71e0, 0xc000055bc0)
/usr/local/go1.14.4/go/src/testing/testing.go:940 +0x421
testing.tRunner.func1(0xc000477680)
/usr/local/go1.14.4/go/src/testing/testing.go:943 +0x600
panic(0xba71e0, 0xc000055bc0)
/usr/local/go1.14.4/go/src/runtime/panic.go:975 +0x3e3
There was a problem hiding this comment.
@BusyJay Can you review this comment , It block my PR test ....
There was a problem hiding this comment.
This is an error that needs to be fixed by the removed commit. I will send it as a separate PR.
There was a problem hiding this comment.
PR is sent as #12163.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Nov 13, 2020
56233: *: upgrade etcd/raft to master r=knz a=tbg We were using a custom fork that we picked up during our vgo transition, but in the meantime upstream has turned `raft` into a small module which has very few deps, and which we can switch back to. Helpfully, this module already pins gogoproto v1.3+, which simplifies PR #56147. I did review the commits we're picking up here in etcd/raft and they look good. The ones worth pointing out are: etcd-io/etcd#12137 etcd-io/etcd#12134 etcd-io/etcd#12163 These all seem to fix real bugs. Release note: None Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
absolute8511
added a commit
to youzan/ZanRedisDB
that referenced
this pull request
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12133.