Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade zap logger to 1.15, replace global logger #12212

Merged
merged 2 commits into from Aug 13, 2020
Merged

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Aug 12, 2020

No description provided.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@jingyih
Copy link
Contributor

jingyih commented Aug 13, 2020

Thanks @gyuho! It is unclear to me what is the global zap logger in etcd?

@jingyih
Copy link
Contributor

jingyih commented Aug 13, 2020

On another topic related to logger, is it still the plan to deprecate logutil.Logger in v3.5?

// TODO: deprecate in v3.5.
type Logger interface {

@gyuho
Copy link
Contributor Author

gyuho commented Aug 13, 2020

On another topic related to logger, is it still the plan to deprecate logutil.Logger in v3.5?

// TODO: deprecate in v3.5.
type Logger interface {

Yes, I believe this is only needed for gRPC.

@gyuho
Copy link
Contributor Author

gyuho commented Aug 13, 2020

Thanks @gyuho! It is unclear to me what is the global zap logger in etcd?

This means now we don't have to pass around *zap.Logger objects.

Just

zap.L().Info(...)

:)

@gyuho gyuho merged commit 06f89cc into etcd-io:master Aug 13, 2020
@gyuho gyuho deleted the logger branch August 13, 2020 16:46
@jingyih
Copy link
Contributor

jingyih commented Aug 13, 2020

Thanks @gyuho! It is unclear to me what is the global zap logger in etcd?

This means now we don't have to pass around *zap.Logger objects.

Just

zap.L().Info(...)

:)

This is awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants