Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG: Update changelog about modules instead of ./vendor #12313

Merged
merged 1 commit into from
Sep 25, 2020
Merged

CHANGELOG: Update changelog about modules instead of ./vendor #12313

merged 1 commit into from
Sep 25, 2020

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented Sep 17, 2020

@ptabor ptabor closed this Sep 22, 2020
@ptabor ptabor reopened this Sep 22, 2020
xiang90
xiang90 reviewed Sep 25, 2020
View reviewed changes
CHANGELOG-3.5.md Outdated Show resolved Hide resolved
@xiang90
Copy link
Contributor

xiang90 commented Sep 25, 2020

lgtm after fixing the nit.

@xiang90
Copy link
Contributor

xiang90 commented Sep 25, 2020

@ptabor

It is still Etcd not etcd. have you pushed your change?

@ptabor
Copy link
Contributor Author

ptabor commented Sep 25, 2020

Fixed. I'm sorry. I misnamed the branch.

@xiang90 xiang90 merged commit 7bf7582 into etcd-io:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiang90 xiang90 xiang90 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptabor @xiang90