Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Content: TOC — Compilation PR (weights & descriptions) #12575

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

nate-double-u
Copy link
Contributor

@nate-double-u nate-double-u commented Dec 22, 2020

Adding weights and descriptions to the Documentation files' frontmatter.

Related to issue etcd-io/website#81

Compilation (fully merged) of the following PRs:

Weights

Descriptions

(compiled together to allow for one commit, keeping the git history a little cleaner).
All feedback provided has been incorporated. These PRs should be closed in favour of this one.

@nate-double-u nate-double-u reopened this Dec 22, 2020
@nate-double-u nate-double-u marked this pull request as draft December 22, 2020 00:56
Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nate-double-u - we can keep all the changes here, can you please squash commits? and close other PRs that are covered here. Thanks!

Updating for new TOC as per issue etcd-io/website#81

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Contributor Author

I've squashed everything into one commit, and gone through and double checked each file.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks @nate-double-u

@spzala
Copy link
Member

spzala commented Dec 23, 2020

/cc @gyuho @xiang90 @jingyih

@spzala spzala merged commit ad5b302 into etcd-io:master Dec 23, 2020
@nate-double-u nate-double-u deleted the 81-docs-toc-compilation branch December 23, 2020 20:28
nate-double-u added a commit to nate-double-u/etcd-io-website that referenced this pull request Jan 1, 2021
* test content dir: content/docs/vcurrent (content from
etcd-io/etcd#12575)

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants