etcdctl: lock return exit code of exec-command #12829
Merged
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garenchan
force-pushed
the
dev/etcdctl-lock
branch
from
e51128b
to
76ad79a
Compare
garenchan
changed the title
ptabor
suggested changes
Apr 5, 2021
There was a problem hiding this comment.
Thank you for the fix. Overall looks good to me.
Please:
- add a line to: https://github.com/etcd-io/etcd/blob/master/CHANGELOG-3.5.md
- add a test, probably to: https://github.com/etcd-io/etcd/blob/master/tests/e2e/ctl_v3_lock_test.go
garenchan
changed the title
garenchan
force-pushed
the
dev/etcdctl-lock
branch
5 times, most recently
from
73715e2
to
fd976a2
Compare
Sometimes we expect to get the exit code of the command being executed.
garenchan
force-pushed
the
dev/etcdctl-lock
branch
from
fd976a2
to
c047ed5
Compare
ptabor
approved these changes
Apr 6, 2021
|
Thank you for the fix & test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/master/CONTRIBUTING.md#contribution-flow.