Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(no)StoreV2 (Part 3): Applying consistency fix: ClusterVersionSet (and co) might get not applied on v2store #12854

Merged
merged 2 commits into from
Apr 21, 2021

Commits on Apr 12, 2021

  1. Applying consistency fix: ClusterVersionSet (and co) might get no app…

    …lied on v2store
    
    ClusterVersionSet, ClusterMemberAttrSet, DowngradeInfoSet functions are
    writing both to V2store and backend. Prior this CL there were
    in a branch not executed if shouldApplyV3 was false,
    e.g. during restore when Backend is up-to-date (has high
    consistency-index) while v2store requires replay from WAL log.
    
    The most serious consequence of this bug was that v2store after restore
    could have different index (revision) than the same exact store before restore,
    so potentially different content between replicas.
    
    Also this change is supressing double-applying of Membership
    (ClusterConfig) changes on Backend (store v3) - that lackilly are not
    part of MVCC/KeyValue store, so they didn't caused Revisions to be
    bumped.
    
    Inspired by jingyih@ comment:
    etcd-io#12820 (comment)
    ptabor committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    b1c04ce View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. Configuration menu
    Copy the full SHA
    d69e46e View commit details
    Browse the repository at this point in the history