Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deflake: TestFirstCommitNotification #12889

Merged

Commits on Apr 23, 2021

  1. Deflake: TestFirstCommitNotification

    Infrequently the test flaked. Reproducable with:
    
    ```
      go test go.etcd.io/etcd/tests/v3/integration --run TestFirstCommitNotification --count=500
    ```
    
    The moveLeader finishes when configchange is commited by quorum.
    It doesn't guarantee that the 'empty' record was committed by the new leader.
    From time to time happened that appliedLeaderIndex was returning 9
    (without empty entry) and the test flaked. In healthy case the
    appliedIndex returned 10.
    
    Fixed by putting kv pair after leader change. The pair is guaranteed
    to be stored on index when put finishes (so the empty entry as well).
    ptabor committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9f55977 View commit details
    Browse the repository at this point in the history