Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functional: add disk io failure case #12898

Merged
merged 3 commits into from
Apr 26, 2021

Conversation

tangcong
Copy link
Contributor

@tangcong tangcong commented Apr 26, 2021

This PR does the following things:

  • fixes a serious bug for the FAILPOINTS case.
  • add functional test case for PR etcdserver: ignore old leader's request to revoke lease #12531. FAILPOINTS and short ttl lease case are very flaky, In order to improve the stability of the test cases, I implemented a new case and checker based on the functional extension mechanism, which can be specified through the configuration file.
 cases:
  - FAILPOINTS_WITH_DISK_IO_LATENCY
   
 failpoint-commands:
  - sleep(3000)

  stressers:
  - type: LEASE
    weight: 0.1

  checkers:
  - SHORT_TTL_LEASE_EXPIRE

@codecov-commenter
Copy link

Codecov Report

Merging #12898 (4fb2209) into master (cc52d99) will decrease coverage by 3.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12898      +/-   ##
==========================================
- Coverage   72.34%   68.51%   -3.83%     
==========================================
  Files         428      408      -20     
  Lines       33888    32799    -1089     
==========================================
- Hits        24515    22471    -2044     
- Misses       7413     8342     +929     
- Partials     1960     1986      +26     
Flag Coverage Δ
all 68.51% <ø> (-3.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raft/quorum/quorum.go 0.00% <0.00%> (-100.00%) ⬇️
raft/tracker/state.go 0.00% <0.00%> (-100.00%) ⬇️
...ver/proxy/grpcproxy/adapter/lock_client_adapter.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/report/report.go 0.00% <0.00%> (-95.58%) ⬇️
pkg/report/timeseries.go 0.00% <0.00%> (-86.77%) ⬇️
pkg/osutil/interrupt_unix.go 0.00% <0.00%> (-82.61%) ⬇️
pkg/osutil/osutil.go 0.00% <0.00%> (-75.00%) ⬇️
pkg/report/weighted.go 0.00% <0.00%> (-69.77%) ⬇️
client/v3/namespace/lease.go 0.00% <0.00%> (-69.24%) ⬇️
server/proxy/grpcproxy/election.go 6.25% <0.00%> (-68.75%) ⬇️
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc52d99...4fb2209. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, awesome thanks!

@gyuho gyuho merged commit c4f7d57 into etcd-io:master Apr 26, 2021
@tangcong
Copy link
Contributor Author

thanks @gyuho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants