Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back original NewZapCoreLoggerBuilder api. #12973

Merged

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented May 15, 2021

The funcion signature has been changed in:
eafbc8c .
Instead we should have added new method NewZapLoggerBuilder().

@ptabor ptabor force-pushed the 20210515-bring-logger-backward-compatibility branch 2 times, most recently from 967e522 to 32139fa Compare May 16, 2021 09:14
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2021

Codecov Report

Merging #12973 (a5aab17) into main (bca0717) will increase coverage by 17.35%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #12973       +/-   ##
===========================================
+ Coverage   47.81%   65.16%   +17.35%     
===========================================
  Files         357      433       +76     
  Lines       28921    34299     +5378     
===========================================
+ Hits        13829    22352     +8523     
+ Misses      13898    10367     -3531     
- Partials     1194     1580      +386     
Flag Coverage Δ
all 65.16% <33.33%> (+17.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/embed/config_logging.go 52.98% <33.33%> (+3.34%) ⬆️
server/auth/simple_token.go 77.14% <0.00%> (-8.58%) ⬇️
etcdctl/ctlv3/command/user_command.go 31.88% <0.00%> (ø)
etcdctl/ctlv2/command/error.go 0.00% <0.00%> (ø)
etcdctl/snapshot/util.go 0.00% <0.00%> (ø)
client/v3/experimental/recipes/double_barrier.go 73.33% <0.00%> (ø)
etcdctl/ctlv3/command/make_mirror_command.go 13.54% <0.00%> (ø)
etcdctl/ctlv3/command/elect_command.go 7.81% <0.00%> (ø)
etcdctl/ctlv3/command/compaction_command.go 25.00% <0.00%> (ø)
client/v3/experimental/recipes/client.go 57.14% <0.00%> (ø)
... and 258 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bca0717...a5aab17. Read the comment docs.

The funcion signature has been changed in:
eafbc8c .
Instead we should have added new method `NewZapLoggerBuilder()`.
@ptabor ptabor force-pushed the 20210515-bring-logger-backward-compatibility branch from 32139fa to a5aab17 Compare May 16, 2021 11:42
@xiang90
Copy link
Contributor

xiang90 commented May 16, 2021

lgtm

@xiang90 xiang90 merged commit f82b5cb into etcd-io:main May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants