netutil: add url comparison without resolver to URLStringsEqual #13224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If one of the nodes in the cluster has lost a dns record, restarting the second node will break it. This PR makes an attempt to add a comparison without using a resolver, which allows to protect cluster from dns errors and does not break the current logic of comparing urls in the URLStringsEqual function. You can read more in the issue #7798 Fixes #7798
lilic
reviewed
Jul 21, 2021
Co-authored-by: Lili Cosic <cosiclili@gmail.com>
ptabor
reviewed
Sep 25, 2021
|
I found a bug in the test |
|
@ptabor please take a look. |
This was referenced Oct 3, 2022
This was referenced Oct 11, 2022
pchan
added a commit
to pchan/etcd
that referenced
this pull request
Oct 12, 2022
Merged
tjungblu
added a commit
to tjungblu/etcd
that referenced
this pull request
Jan 5, 2023
PR etcd-io#13224 introduced an early exit when the names match. This change restores the previous behaviour by doing an explicit DNS resolution before checking the URLs for equality. Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one of the nodes in the cluster has lost a dns record,
restarting the second node will break it.
This PR makes an attempt to add a comparison without using a resolver,
which allows to protect cluster from dns errors and does not break
the current logic of comparing urls in the URLStringsEqual function.
You can read more in the issue #7798
Fixes #7798
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.