New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: build with consistent paths #13552
Conversation
Is this something that there's any interest in? |
1bc1553
to
0b5ef0f
Compare
I have rebased this branch since there were conflicts with |
Codecov Report
@@ Coverage Diff @@
## main #13552 +/- ##
=======================================
Coverage 75.17% 75.17%
=======================================
Files 452 452
Lines 36770 36770
=======================================
Hits 27643 27643
Misses 7393 7393
Partials 1734 1734
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
0b5ef0f
to
830afdb
Compare
Have done this again, is there interest in this or should I close it? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
830afdb
to
370d037
Compare
I have updated again, but still have the same question 😄. |
Thanks for your resilience, sorry that the PR got lost. Looks like you haven't signed the commit. I would like to include this in latest release so let me fix that. |
Ah, I think maybe that's new since this originally was opened? I can update the PR here and do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this change removes build GOPATH from binary strings, which is important for release scripts.
This changes the builds to always add -trimpath which removes specific build time paths from the binary (like current directories etc). Improves build reproducability to make the final binary independent from the specific build path. Lastly, when stripping debug symbols, also add -w to strip DWARF symbols as well which aren't needed in that case either. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
370d037
to
c26daba
Compare
@serathius Rebased and added the signature! |
This changes the builds to always add -trimpath which removes specific build time paths from the binary (like current directories etc).
Improves build reproducability to make the final binary independent from the specific build path.
Lastly, when stripping debug symbols, also add -w to strip DWARF symbols as well which aren't needed in that case either.
Found this when doing #13545 and thought that maybe these additional changes would also be welcome.