Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Fix cluster version and downgrade request timeout #13694

Merged
merged 1 commit into from Feb 14, 2022

Conversation

serathius
Copy link
Member

Returning nil means that raft.Trigger was not called, causing member to
wait infinitly for response for response on raft request.

cc @ptabor @ahrtr @spzala

@serathius serathius changed the title tests: Fix timeouts downgrade requests tests: Fix cluster version and downgrade request timeout Feb 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #13694 (d261ffc) into main (bcadd03) will increase coverage by 0.06%.
The diff coverage is 42.85%.

❗ Current head d261ffc differs from pull request most recent head b599a33. Consider uploading reports for the commit b599a33 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13694      +/-   ##
==========================================
+ Coverage   72.51%   72.57%   +0.06%     
==========================================
  Files         465      465              
  Lines       37865    37872       +7     
==========================================
+ Hits        27457    27485      +28     
+ Misses       8620     8604      -16     
+ Partials     1788     1783       -5     
Flag Coverage Δ
all 72.57% <42.85%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdserver/apply.go 89.32% <33.33%> (ø)
server/storage/mvcc/index.go 90.25% <33.33%> (-2.41%) ⬇️
server/auth/simple_token.go 88.46% <50.00%> (+7.35%) ⬆️
server/etcdserver/version/version.go 44.82% <100.00%> (ø)
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) ⬇️
server/etcdserver/api/v3rpc/member.go 93.54% <0.00%> (-3.23%) ⬇️
client/v3/leasing/kv.go 89.03% <0.00%> (-1.67%) ⬇️
server/lease/leasehttp/http.go 64.23% <0.00%> (-1.46%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 76.92% <0.00%> (-1.29%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcadd03...b599a33. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

server/etcdserver/apply.go Outdated Show resolved Hide resolved
server/etcdserver/apply.go Outdated Show resolved Hide resolved
server/etcdserver/apply.go Outdated Show resolved Hide resolved
@serathius serathius force-pushed the timeout branch 3 times, most recently from 5898e64 to b599a33 Compare February 13, 2022 22:00
Returning nil means that raft.Trigger was not called, causing member to
wait infinitly for response for response on raft request.
@ptabor ptabor merged commit 9ebaf58 into etcd-io:main Feb 14, 2022
@serathius serathius deleted the timeout branch June 15, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants