[3.5] Trim the suffix dot from the srv.Target for etcd-client DNS lookup #13714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
force-pushed
the
3.5_correct_dns_etcd_client
branch
from
4a49c6d
to
4f51cc1
Compare
spzala
approved these changes
Feb 20, 2022
serathius
approved these changes
Feb 20, 2022
This was referenced Apr 15, 2022
Closed
ptabor
added a commit
that referenced
this pull request
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back port the PR 13712 to 3.5
Usually the SRV records returned by DNS lookup have a trailing dot but URL shouldn't, so we should trim the suffix dot. We have already trimmed the suffix dot when bootstrapping etcd server ( see srv.go#L72 ), but not for etcd client.
cc @serathius @spzala @ptabor