New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Test both fast memory and slower disk mounted filesystem #13927
Conversation
ee69b22
to
9ff5760
Compare
Codecov Report
@@ Coverage Diff @@
## main #13927 +/- ##
==========================================
+ Coverage 72.51% 72.57% +0.05%
==========================================
Files 469 469
Lines 38411 38411
==========================================
+ Hits 27853 27875 +22
+ Misses 8778 8754 -24
- Partials 1780 1782 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b795dab
to
811cc97
Compare
I think the mounted ramfs only makes sense for functional/stress test? |
Interesting enough, #13922 detected by integration tests was only reproducable on ramfs and not hdd. If we want to depend on ETCD_VERIFY checks in integration tests we should also cover different disk performance. |
Not really, I reproduced the issue on my a linux VM (not powerful, 2CPU, 8GB RAM) on hdd. Somehow I couldn't reproduce this issue on my local MacBook, which is more powerful (2.4 GHz 8-Core Intel Core i9, 32 GB 2667 MHz DDR4). |
@@ -20,14 +22,32 @@ jobs: | |||
run: | | |||
echo "${TARGET}" | |||
case "${TARGET}" in | |||
linux-amd64-e2e) | |||
linux-amd64-e2e-release) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth to maintain the 'release', that seems to be just 'unopinionated' variant of the same tasts as ramfs vs. ext4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test fails:
Error: EACCES: permission denied, scandir '/home/runner/work/etcd/etcd/ext4/lost+found'
This will require a high level design. |
Appearance of data corruption issues depends on disk performance characteristics. In our current testing we only check one type (expect
tmpfs
usually mounted in linux under/tmp
).This PR adds test jobs that ensure that we cover both in memory and hdd disk as a short term solution for the problem.