Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback the opentelemetry bumpping to recover the pipeline failures #13945

Merged
merged 1 commit into from
Apr 16, 2022

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 14, 2022

Fix issue 13944

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2022

Codecov Report

Merging #13945 (0dae4b3) into main (ff1569f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13945      +/-   ##
==========================================
- Coverage   72.52%   72.51%   -0.02%     
==========================================
  Files         469      469              
  Lines       38414    38414              
==========================================
- Hits        27861    27855       -6     
+ Misses       8783     8773      -10     
- Partials     1770     1786      +16     
Flag Coverage Δ
all 72.51% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-20.94%) ⬇️
server/etcdserver/api/rafthttp/peer_status.go 87.87% <0.00%> (-12.13%) ⬇️
server/etcdserver/api/rafthttp/peer.go 87.01% <0.00%> (-8.45%) ⬇️
client/pkg/v3/tlsutil/tlsutil.go 83.33% <0.00%> (-8.34%) ⬇️
client/v3/namespace/watch.go 87.87% <0.00%> (-6.07%) ⬇️
client/v3/leasing/txn.go 88.09% <0.00%> (-3.18%) ⬇️
server/etcdserver/metrics.go 81.63% <0.00%> (-2.05%) ⬇️
server/etcdserver/api/v3rpc/watch.go 85.90% <0.00%> (-2.02%) ⬇️
client/v3/leasing/cache.go 87.77% <0.00%> (-1.67%) ⬇️
client/v3/leasing/kv.go 89.03% <0.00%> (-1.67%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1569f...0dae4b3. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Apr 14, 2022

cc @serathius @ptabor @spzala

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting previous changes and do these changes in a multiple PRs (opentelemetry and other components ) looks good to me. Thanks @ahrtr

@ptabor
Copy link
Contributor

ptabor commented Apr 16, 2022

I'm sorry. The pre-squash commit was green and I rushed too much.

@ptabor ptabor merged commit 8149191 into etcd-io:main Apr 16, 2022
This was referenced Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants