Backport PR 13308 to release 3.4 #13999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying To fix a bug in the retry logic caused when the auth token is cleared after receiving `ErrInvalidAuthToken` from the server and the subsequent call to `getToken` also fails due to some reason (eg. context deadline exceeded). This leaves the client without a token and the retry will continue to fail with `ErrUserEmpty` unless the token is refreshed.
mitake
changed the title
|
@ahrtr I tested this PR on my local env and it resolved the issue, could you review? |
|
Thanks @mitake . Looks good to me. I also did some sanity test, and looks good. I think this PR is good to go. @ptabor @serathius @spzala The pipeline failures should have nothing to do with this PR. I just submitted a verification PR (which has only a minor change on README.md), and there are also some failures. |
ahrtr
approved these changes
May 5, 2022
ptabor
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is backporting #13308 to release-3.4 like #13477.
Fix #13976
todo:
mainbranch: Update CHANGELOG for PR 13999 #14005