memberID equals zero in corruption alarm #14272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
memberID
branch
2 times, most recently
from
0f0358a
to
7645ac7
Compare
serathius
force-pushed
the
memberID
branch
2 times, most recently
from
6e3b284
to
a798812
Compare
serathius
changed the title
Codecov Report
@@ Coverage Diff @@
## main #14272 +/- ##
==========================================
- Coverage 75.40% 75.24% -0.16%
==========================================
Files 456 456
Lines 36919 36946 +27
==========================================
- Hits 27838 27800 -38
- Misses 7345 7394 +49
- Partials 1736 1752 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
ahrtr
reviewed
Jul 26, 2022
| @@ -16,6 +16,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
| - Fix [lessor may continue to schedule checkpoint after stepping down leader role](https://github.com/etcd-io/etcd/pull/14087). | |||
| - Fix [Restrict the max size of each WAL entry to the remaining size of the WAL file](https://github.com/etcd-io/etcd/pull/14127). | |||
| - Fix [Protect rangePermCache with a RW lock correctly](https://github.com/etcd-io/etcd/pull/14227) | |||
| - Fix [memberID equals zero in corruption alarm](https://github.com/etcd-io/etcd/pull/14272) | |||
There was a problem hiding this comment.
I assume you will update this once the PR is backported to 3.5?
|
ping @ahrtr |
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
|
@ahrtr It might be worth considering backporting this to v3.4 release as currently corruption checks will not report which member is corrupted making the restore process require manually finding corrupted member. |
|
Sure, let me take care of it for 3.4. |
This was referenced Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ahrtr