Replace github.com/form3tech-oss/jwt-go with https://github.com/golang-jwt/jwt #14489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dims
force-pushed
the
Haimantika-replacejwtgo-in-release-3.5
branch
from
c2083c8
to
2d4cdf4
Compare
dims
changed the title
dims
force-pushed
the
Haimantika-replacejwtgo-in-release-3.5
branch
from
2d4cdf4
to
8be6210
Compare
…g-jwt/jwt/v4 Signed-off-by: haimantika mitra <haimantikamitra@gmail.com> Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
Haimantika-replacejwtgo-in-release-3.5
branch
from
8be6210
to
653d6e1
Compare
dims
changed the title
|
ok, should be ready now! thanks. @ahrtr please feel free to update master to this same version. |
Sure. Thanks @dims . Usually we keep the backporting PR as it's. Specifically I would suggest to bump to 4.4.2 in the main branch firstly, and cherry pick to 3.5 and 3.4 later. But I won't insist on that. Anyway, let me take care of the main branch to bumping 4.4.2. Thanks again. |
|
thanks @ahrtr ! |
|
FYI. I just delivered a PR to take care of the main branch #14491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #13256 to release-3.5 branch
form3tech fork is outdated as well :( (introduced in #12580)
So pick up the changes from @Haimantika in #13256 from main to release-3.5 (At one point we were waiting for 3.6, but given that otel changes got picked to 3.5, we should do this as well.
Longer term plan was to ensure k/k only depends on
github.com/golang-jwt/jwt, see:Also note that form3tech is no longer active as well. So better to switch to something where we can get help if needed.
Signed-off-by: haimantika mitra haimantikamitra@gmail.com
Signed-off-by: Davanum Srinivas davanum@gmail.com