Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Backport update to latest go 1.19.7 release #15428

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Mar 8, 2023

Mitigates CVE-2023-24532, refer: https://groups.google.com/g/golang-dev/c/3wmx8i5WvNY/m/AEOlccrGAwAJ?utm_medium=email&utm_source=footer

Relates to #15426

/area security

Note: I somehow missed some nested go.mod updates from 1.17 to 1.19 when I previously backported 1.19.6 update so I am tidying up those in this pull request also.

Mitigates CVE-2023-24532.

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz jmhbnz changed the title [3.5] Backport update to latest go to 1.19.7 release [3.5] Backport update to latest go 1.19.7 release Mar 8, 2023
@ahrtr
Copy link
Member

ahrtr commented Mar 8, 2023

Please also update the changelog for both 3.5 and 3.4. @jmhbnz

@ahrtr ahrtr merged commit b10adb6 into etcd-io:release-3.5 Mar 8, 2023
@jmhbnz
Copy link
Member Author

jmhbnz commented Mar 8, 2023

Please also update the changelog for both 3.5 and 3.4. @jmhbnz

Hey @ahrtr recently when we backported 1.19.6 to 3.5 and 3.4 we added generic go changelog entries to state the migration to 1.19+. Should we make these more specific to go minor release, or are the existing CHANGELOG entries ok?

Example: https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md#go

Go

@ahrtr
Copy link
Member

ahrtr commented Mar 8, 2023

Right, the existing CHANGELOG entries seem OK. The only minor comment is it's still linking to the previous PR. It shouldn't a big deal, as we may continue to bump go minor version in following patch release. Let's leave it as it's if there is no concern from other maintainers.

tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
[3.5] Backport update to latest go 1.19.7 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants