Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3.5] Fix issue15271 #15515

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Conversation

serathius
Copy link
Member

Backport #15492
cc @ahrtr @ptabor

Bogdan Kanivets and others added 2 commits March 20, 2023 12:02
Problem: during restore in watchableStore.Restore, synced watchers are moved to unsynced.
minRev will be behind since it's not updated when watcher stays synced.

Solution: update minRev

fixes: etcd-io#15271
Signed-off-by: Bogdan Kanivets <bkanivets@apple.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serathius serathius merged commit 15b3756 into etcd-io:release-3.5 Mar 20, 2023
utkuozdemir added a commit to utkuozdemir/cosi-state-etcd that referenced this pull request Apr 13, 2023
Bump etcd libraries to v3.5.8 to include the fix: etcd-io/etcd#15515

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir added a commit to utkuozdemir/cosi-state-etcd that referenced this pull request Apr 13, 2023
Bump etcd libraries to v3.5.8 to include the fix: etcd-io/etcd#15515

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir added a commit to utkuozdemir/cosi-state-etcd that referenced this pull request Apr 13, 2023
Bump etcd libraries to v3.5.8 to include the fix: etcd-io/etcd#15515

Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants