Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: clear password after authenticating the user #15648

Merged
merged 2 commits into from Apr 6, 2023

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Apr 6, 2023

Fix https://nvd.nist.gov/vuln/detail/CVE-2021-28235

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

cc @mitake @ptabor @serathius @spzala

The issue can only happen when all the following conditions are true:

  1. The auth is enabled;
  2. The log level is set to "debug";
  3. Clients send authentication request to etcdserver with username & password. Note that clients send authentication request automatically when reading or writing data.

@ahrtr ahrtr marked this pull request as draft April 6, 2023 05:57
@ahrtr ahrtr marked this pull request as ready for review April 6, 2023 08:16
@ahrtr ahrtr force-pushed the auth_cve_20230406 branch 2 times, most recently from e592294 to 828002f Compare April 6, 2023 08:33
@ahrtr ahrtr changed the title security: remove password after authenticating the user security: clear password after authenticating the user Apr 6, 2023
@ahrtr
Copy link
Member Author

ahrtr commented Apr 6, 2023

@mitake @ptabor PTAL

@mitake
Copy link
Contributor

mitake commented Apr 6, 2023

LGTM, thanks a lot @ahrtr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants