Update CHANGELOG for #16029 #16165 #16193 #16194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jul 7, 2023
CHANGELOG/CHANGELOG-3.4.md
Outdated
| @@ -13,6 +13,9 @@ Previous change logs can be found at [CHANGELOG-3.3](https://github.com/etcd-io/ | |||
| ### Dependencies | |||
| - Compile binaries using [go 1.19.10](https://github.com/etcd-io/etcd/pull/16038). | |||
|
|
|||
| ### etcdutl v3 | |||
There was a problem hiding this comment.
3.4 doesn't have etcdutl.
Suggested change
| ### etcdutl v3 | |
| ### etcdctl v3 |
There was a problem hiding this comment.
minor comment: also usually we put the section ### Dependencies at the end. So suggest to put this section to above it.
There was a problem hiding this comment.
Ah, too long since I updated last time.. Thank you very much! I will update changelog for 3.5 and 3.6 once this is merged.
There was a problem hiding this comment.
I think we can update all changelog in this PR. But it isn't a big deal.
wenjiaswe
force-pushed
the
patch-1
branch
2 times, most recently
from
bee7c38
to
4190405
Compare
wenjiaswe
changed the title
wenjiaswe
force-pushed
the
patch-1
branch
2 times, most recently
from
afc0a94
to
ef4802f
Compare
ahrtr
reviewed
Jul 7, 2023
| @@ -10,6 +10,9 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
| - Fix [corruption check may get a `ErrCompacted` error when server has just been compacted](https://github.com/etcd-io/etcd/pull/16048) | |||
| - Improve [Lease put performance for the case that auth is disabled or the user is admin](https://github.com/etcd-io/etcd/pull/16019) | |||
|
|
|||
| ### etcdutl v3 | |||
| - Add [optional --bump-revision and --mark-compacted flag to etcdutl snapshot restore operation](https://github.com/etcd-io/etcd/pull/16165). | |||
There was a problem hiding this comment.
We also updated the etcdctl snapshot restore command in 3.5.
There was a problem hiding this comment.
Oops, added. Thanks!
Signed-off-by: Wenjia Zhang <wenjiazhang@google.com>
serathius
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.