v3rpc: online defrag toggles gRPC health server serving status #16836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaochn47
force-pushed
the
defrag_follow_up
branch
4 times, most recently
from
0d65345
to
a53af18
Compare
|
cc @serathius |
serathius
reviewed
Oct 27, 2023
serathius
reviewed
Oct 27, 2023
serathius
reviewed
Oct 27, 2023
chaochn47
force-pushed
the
defrag_follow_up
branch
2 times, most recently
from
65a95ef
to
36059b5
Compare
chaochn47
changed the title
chaochn47
changed the title
serathius
reviewed
Oct 28, 2023
serathius
approved these changes
Oct 28, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
defrag_follow_up
branch
from
36059b5
to
8a6c133
Compare
ahrtr
approved these changes
Oct 29, 2023
| type HealthNotifier interface { | ||
| StartServe() | ||
| StopServe(reason string) | ||
| type notifier interface { |
There was a problem hiding this comment.
Nit: The previous name HealthNotifier makes more sense than notifier, because it isn't defined inside package "health".
Overall this PR is a little over-engineering. Both (*maintenanceServer) Defragment and (*healthChecker) StopServe are in the same package api/v3rpc, we don't have to necessarily introduce or refine the interface for now.
Anyway, not a big deal for now.
There was a problem hiding this comment.
On the other side, we should avoid the other extreme. Fact that structs are in single package doesn't mean that they should access all internal methods. Having a internal interface doesn't complicate code too much, but it clarifies the interned usage.
tjungblu
added a commit
to tjungblu/etcd
that referenced
this pull request
May 6, 2024
Backport from 3.6 in etcd-io#16836 Co-authored-by: Chao Chen <chaochn@amazon.com> Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #16278
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.