Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: Printing etcd backend database related metrics inside scheduleCompaction function #17204

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

rahulbapumore
Copy link
Contributor

To improve traceability of backend database usage, Added below parameter related to backend database usage metrics inside scheduledCompaction function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use
Signed-off-by: Rahul More rahulbapumore@gmail.com

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @rahulbapumore. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@serathius
Copy link
Member

I left a comment in related issue #17179 (comment)

Let's discuss it there.

@ahrtr
Copy link
Member

ahrtr commented Jan 15, 2024

@rahulbapumore
Copy link
Contributor Author

Hi @ahrtr
Done

@@ -20,7 +20,7 @@ import (
"time"

"go.uber.org/zap"

humanize "github.com/dustin/go-humanize"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also put this item right above "go.uber.org/zap"

Suggested change
humanize "github.com/dustin/go-humanize"
humanize "github.com/dustin/go-humanize"

"go.uber.org/zap"

Copy link
Member

@ahrtr ahrtr Jan 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls keep the blank line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

@rahulbapumore rahulbapumore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved
humanize "github.com/dustin/go-humanize"
above
"go.uber.org/zap"

@rahulbapumore
Copy link
Contributor Author

rahulbapumore commented Jan 15, 2024

Hi @ahrtr ,
Please let me know if any comments?

scheduleCompaction function

To improve traceability of backend database usage, Added below parameter
related to backend database usage metrics inside scheduledCompaction
function.
current-db-size-bytes
current-db-size
current-db-size-in-use-bytes
current-db-size-in-use

Signed-off-by: Rahul More <rahulbapumore@gmail.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cc @serathius

@ahrtr ahrtr merged commit 4bc55e5 into etcd-io:main Jan 15, 2024
35 checks passed
@rahulbapumore
Copy link
Contributor Author

Thanks @ahrtr for merging changes

@rahulbapumore
Copy link
Contributor Author

Hi @ahrtr ,
Could you please let us know in which version of ETCD this change will be visible?
And expected release date?

Thanks

@ahrtr
Copy link
Member

ahrtr commented Jan 17, 2024

Could you please let us know in which version of ETCD this change will be visible?
And expected release date?

It will only be included in 3.6, and the release date isn't finalised yet.

You want to backport the PR to 3.5 and. 3.4? I have no objection on it.

@rahulbapumore
Copy link
Contributor Author

rahulbapumore commented Jan 19, 2024

Could you please let us know in which version of ETCD this change will be visible?
And expected release date?

It will only be included in 3.6, and the release date isn't finalised yet.

You want to backport the PR to 3.5 and. 3.4? I have no objection on it.

Hi @ahrtr ,
It will be helpful if we can backport it to 3.5 version atleast.
shall I again raise pull request for that also?

Thanks

@ahrtr
Copy link
Member

ahrtr commented Jan 19, 2024

shall I again raise pull request for that also?

It's OK for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants