Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Backport ignore SetKeepAlivePeriod errors on OpenBSD #17387

Merged

Conversation

Elbehery
Copy link
Contributor

@Elbehery Elbehery commented Feb 6, 2024

This is a backport of #15812

cc @ahrtr

Added keepalive_listener_unix.go and keepalive_listener_openbsd.go to
handle SetKeepAlivePeriod() specially on OpenBSD.

Signed-off-by: Ruize Tang <1466040111@qq.com>
@k8s-ci-robot
Copy link

Hi @Elbehery. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahrtr ahrtr changed the title etcd: Add OpenBSD-specific files for SetKeepAlivePeriod handling [3,.5] Add OpenBSD-specific files for SetKeepAlivePeriod handling Feb 6, 2024
@ahrtr ahrtr changed the title [3,.5] Add OpenBSD-specific files for SetKeepAlivePeriod handling [3.5] ignore SetKeepAlivePeriod errors on OpenBSD Feb 6, 2024
@Elbehery Elbehery changed the title [3.5] ignore SetKeepAlivePeriod errors on OpenBSD [3.5] Backport ignore SetKeepAlivePeriod errors on OpenBSD Feb 6, 2024
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cc @serathius

@ahrtr
Copy link
Member

ahrtr commented Feb 7, 2024

/ok-to-test

@ahrtr ahrtr merged commit c2b458c into etcd-io:release-3.5 Feb 7, 2024
15 checks passed
@Elbehery Elbehery deleted the backport_35_SetKeepAlivePeriod_OpenBSD branch February 16, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants