Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] *: LeaseTimeToLive returns error if leader changed #17704

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[3.5] *: LeaseTimeToLive returns error if leader changed #17704

merged 2 commits into from
Apr 5, 2024
+131 −5

Conversation

fuweid
Copy link
Contributor

@fuweid fuweid commented Apr 4, 2024

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fuweid fuweid marked this pull request as ready for review April 4, 2024 07:30
@fuweid
Copy link
Contributor Author

fuweid commented Apr 4, 2024

hold it until bump go version

@ahrtr
Copy link
Member

ahrtr commented Apr 4, 2024

Please rebase this PR, the go version has already been bumped.

@fuweid
.github: enable failpoints for integration tests
b78b214 
And introduce helper to toggle failpoints by makefile.

Signed-off-by: Wei Fu <fuweid89@gmail.com>
@fuweid
*: LeaseTimeToLive returns error if leader changed
94a1d0c 
The old leader demotes lessor and all the leases' expire time will be
updated. Instead of returning incorrect remaining TTL, we should return
errors to force client retry.

Cherry-pick: d3bb6f6

Signed-off-by: Wei Fu <fuweid89@gmail.com>
ahrtr
ahrtr approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ahrtr
Copy link
Member

ahrtr commented Apr 4, 2024

Link to #17506

@ahrtr ahrtr merged commit 86d9874 into etcd-io:release-3.5 Apr 5, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fuweid @k8s-ci-robot @ahrtr @serathius